Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Bring back fullscreen hint #436

Open
wants to merge 2 commits into
base: xenial
Choose a base branch
from

Conversation

kugiigi
Copy link
Contributor

@kugiigi kugiigi commented Dec 30, 2020

Added back the fullscreen hint that shows up when the webview goes fullscreen i.e. fullscreen video

@UniversalSuperBox
Copy link
Member

Hmm... While the hint is correct sometimes, I'm having a lot of trouble triggering the "swipe up" action. Is it the bottom edge swipe? Can we make that clearer?

@kugiigi
Copy link
Contributor Author

kugiigi commented Feb 4, 2021

Hmm... While the hint is correct sometimes, I'm having a lot of trouble triggering the "swipe up" action. Is it the bottom edge swipe? Can we make that clearer?

Yes, it's a bottom swipe which is exactly the same as before.
Do you mean we should change the label to something like below?
Swipe Up From The Bottom To Exit Full Screen
or
Bottom Swipe To Exit Full Screen for a shorter version.

@UniversalSuperBox
Copy link
Member

Hmm... maybe something like Swipe from the bottom edge to exit Full Screen... It's a weird interaction in any case, but it should do.

We could also bring this text up from the bottom of the screen rather than the top.

Other options include maintaining the bottom edge interaction method, where a hint appears for a short time followed by a chevron... but we'd need to be careful to avoid the chevron getting in the way of page content or conflicting with the real tab pip.

@UniversalSuperBox
Copy link
Member

Oh, one more thing (sorry)... On my tablet, which doesn't have a physical keyboard, the hint unhelpfully says "Press ESC to exit full screen"

@kugiigi
Copy link
Contributor Author

kugiigi commented Feb 5, 2021

I moved it to the bottom and changed the text. I've also fixed issue with the text when in wide layout.
As for the chevron, I'm not sure if it's a good idea since you don't want anything shown on top of a playing video.
I feel like the hint is enough.

@mateosalta
Copy link
Contributor

yeah, for some reason if you try to roll your own bottom edge - not the one with cheveron/hint, it doesn't trigger as well, I think there are extra things they are doing for swipe usability too

@mateosalta
Copy link
Contributor

qtwebbrowser does a scroll tracker and when you drag on the screen it brings a hidden bar in sight

@UniversalSuperBox
Copy link
Member

Morph also has one -- well, webbrowser-app had one, and it got disabled when it became Morph. #333

Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now appears to include changes from #417 and #429. Please edit the branch so it only includes the changes needed to bring back the fullscreen hint, or recreate this PR as appropriate.

@kugiigi
Copy link
Contributor Author

kugiigi commented Jul 15, 2021

Yeah sorry, I combined all my open PRs into one, didn't know fixing conflicts does this 😅
It's good now 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants